Fix documentation on RegularPolygon #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `RegularPolygon` is described by the circumscribed radius, not the inscribed radius.
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
james7132
added
C-Docs
mockersf
approved these changes
Mar 22, 2023
Co-authored-by: Paul Hüber <45110470+p-hueber@users.noreply.github.com>
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
@p-hueber once this is passing CI I'll merge this in for you :) |
|
@alice-i-cecile thanks, I pushed a white-space fixup. Do you need me to squash anything? |
|
We squash on merge here, and try not to worry too much about commit history within PRs. |
mockersf
pushed a commit
that referenced
this pull request
Mar 27, 2023
A `RegularPolygon` is described by the circumscribed radius, not the inscribed radius. ## Objective - Correct documentation for `RegularPolygon` ## Solution - Use the correct term --------- Co-authored-by: Paul Hüber <phueber@kernsp.in> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
RegularPolygonis described by the circumscribed radius, not the inscribed radius.Objective
RegularPolygonSolution