Expose AudioSink::empty()
#8145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
cart
reviewed
Mar 21, 2023
examples/audio/audio_empty.rs
Outdated
| @@ -0,0 +1,35 @@ | |||
| use bevy::prelude::*; | |||
There was a problem hiding this comment.
Definitely a matter of preference, but I don't think we need an example just to illustrate the empty method. With that criteria we'd have thousands of examples.
There was a problem hiding this comment.
You could update one of the existing audio example, like audio_control, to exit once the sink is empty
There was a problem hiding this comment.
I just think its solving a problem that doesn't need to be solved. I think we should wait until the demand for such an example presents itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Exposes
empty()method forAudioSink.Based on
0.10.0, should be a non-breaking change.Changelog
empty()method forAudioSinkAudioSink::empty()example