Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process 1 in Chrome tracing starts expanded #8024

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Process 1 in Chrome tracing starts expanded #8024

merged 1 commit into from
Mar 11, 2023

Conversation

alice-i-cecile
Copy link
Member

Objective

  • the docs remind you to expand process 1, but it now starts expanded

Solution

  • Remove this suggestion

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation C-Testing A change that impacts how we test Bevy or how users test their apps labels Mar 10, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 11, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 11, 2023
Merged via the queue into main with commit ee0e6f4 Mar 11, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@alice-i-cecile @Shfty
Process 1 in Chrome tracing starts expanded (bevyengine#8024)
dfddb87
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@alice-i-cecile @Shfty
Process 1 in Chrome tracing starts expanded (bevyengine#8024)
57594da
@mockersf mockersf deleted the alice-i-cecile-tracing-docs-nit branch March 27, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoJoJet JoJoJet JoJoJet approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alice-i-cecile @JoJoJet