Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused_variables warning when building with filesystem_watcher feature disabled #7938

Merged
merged 2 commits into from
Mar 14, 2023
Merged

unused_variables warning when building with filesystem_watcher feature disabled #7938

merged 2 commits into from
Mar 14, 2023

Conversation

sarkahn
Copy link
Contributor

@sarkahn sarkahn commented Mar 7, 2023 •
edited
Loading

Objective

Fix unused_variables warning produced by bevy_asset when building as a local dependency with the filesystem_watcher feature disabled.

https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/io/file_asset_io.rs#L125-L143

For some reason this warning doesn't seem to be produced when using the crates.io dependency - I only observed it with a local copy of bevy 0.10

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A simple quality-of-life change that makes Bevy easier to use labels Mar 7, 2023
@james7132 james7132 enabled auto-merge March 8, 2023 05:52
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 8, 2023
@alice-i-cecile
Copy link
Member

@sarkahn can you try rebasing this? CI appears to be stuck.

auto-merge was automatically disabled March 13, 2023 16:59

Head branch was pushed to by a user without write access

@mockersf
Copy link
Member

mockersf commented Mar 13, 2023 •
edited
Loading

something like #[cfg_attr(not(feature = "filesystem_watcher"), allow(unused_variables))] would be more exact. I don't remember the exact syntax though

@james7132 james7132 requested a review from mockersf March 14, 2023 02:31
@mockersf mockersf added this pull request to the merge queue Mar 14, 2023
Merged via the queue into bevyengine:main with commit 520e413 Mar 14, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@sarkahn @Shfty
unused_variables warning when building with filesystem_watcher fe…
5cb5e96 
…ature disabled (bevyengine#7938)
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@sarkahn @Shfty
unused_variables warning when building with filesystem_watcher fe…
e165c95 
…ature disabled (bevyengine#7938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarkahn @alice-i-cecile @mockersf @james7132