Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Recreate tonemapping bind group if view uniforms buffer has changed #7904

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Recreate tonemapping bind group if view uniforms buffer has changed #7904

wants to merge 1 commit into from

Conversation

geieredgar
Copy link
Contributor

Objective

Solution

  • Check if the buffer id of the view uniforms buffer has changed and create a new bind group if it did.

@geieredgar geieredgar changed the title Recrate tonemapping bind group if view uniforms buffer has changed Recreate tonemapping bind group if view uniforms buffer has changed Mar 5, 2023
@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Mar 5, 2023
superdump
superdump approved these changes Mar 5, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense. I see on discord that robtfm has tested after earlier being able to reproduce the problem and now cannot after this fix.

bors r+

bors bot pushed a commit that referenced this pull request Mar 5, 2023
@geieredgar
Recreate tonemapping bind group if view uniforms buffer has changed (#…
05b1a6d 
…7904)

# Objective

- Currently, https://github.com/vleue/bevy_bistro_playground crashes when enabling shadows, because this allocates a new buffer for the view uniforms, but the `TonemappingNode` uses a cached bind group that doesn't reference the new uniform buffer.

## Solution

- Check if the buffer id of the view uniforms buffer has changed and create a new bind group if it did.
@bors
Copy link
Contributor

bors bot commented Mar 5, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Recreate tonemapping bind group if view uniforms buffer has changed [Merged by Bors] - Recreate tonemapping bind group if view uniforms buffer has changed Mar 5, 2023
@bors bors bot closed this Mar 5, 2023
@robtfm robtfm mentioned this pull request Mar 12, 2023
Merged
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@geieredgar @Shfty
Recreate tonemapping bind group if view uniforms buffer has changed (b…
553e52a 
…evyengine#7904)

# Objective

- Currently, https://github.com/vleue/bevy_bistro_playground crashes when enabling shadows, because this allocates a new buffer for the view uniforms, but the `TonemappingNode` uses a cached bind group that doesn't reference the new uniform buffer.

## Solution

- Check if the buffer id of the view uniforms buffer has changed and create a new bind group if it did.
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@geieredgar @Shfty
Recreate tonemapping bind group if view uniforms buffer has changed (b…
6ad112b 
…evyengine#7904)

# Objective

- Currently, https://github.com/vleue/bevy_bistro_playground crashes when enabling shadows, because this allocates a new buffer for the view uniforms, but the `TonemappingNode` uses a cached bind group that doesn't reference the new uniform buffer.

## Solution

- Check if the buffer id of the view uniforms buffer has changed and create a new bind group if it did.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@robtfm robtfm robtfm approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geieredgar @superdump @robtfm @james7132