Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use Image::default for 1 pixel white texture directly #7884

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Use Image::default for 1 pixel white texture directly #7884

wants to merge 1 commit into from

Conversation

shuoli84
Copy link
Contributor

@shuoli84 shuoli84 commented Mar 3, 2023

for place holder image, it should use default directly.

@shuoli84 shuoli84 marked this pull request as ready for review March 3, 2023 16:12
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Mar 3, 2023
@james7132 james7132 requested a review from superdump March 3, 2023 19:52
superdump
superdump approved these changes Mar 4, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Mar 4, 2023
@shuoli84
Use Image::default for 1 pixel white texture directly (#7884)
0b794c8 
for place holder image, it should use `default` directly.
@bors
Copy link
Contributor

bors bot commented Mar 4, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Use Image::default for 1 pixel white texture directly [Merged by Bors] - Use Image::default for 1 pixel white texture directly Mar 4, 2023
@bors bors bot closed this Mar 4, 2023
@shuoli84 shuoli84 deleted the image_default_fix branch March 4, 2023 13:22
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@shuoli84 @Shfty
Use Image::default for 1 pixel white texture directly (bevyengine#7884)
6be3d97 
for place holder image, it should use `default` directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuoli84 @superdump @alice-i-cecile