Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bevy_reflect: Add missing primitive registrations #7815

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - bevy_reflect: Add missing primitive registrations #7815

wants to merge 1 commit into from

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Feb 25, 2023 •
edited
Loading

Objective

There were a couple primitive types missing from the default TypeRegistry constructor.

Solution

Added the missing registrations for char and String.

@MrGVSV MrGVSV added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Feb 25, 2023
@MrGVSV MrGVSV added this to the 0.10 milestone Feb 25, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 25, 2023
@james7132
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 25, 2023
@MrGVSV
bevy_reflect: Add missing primitive registrations (#7815)
a89277d 
# Objective

There were a couple primitive types missing from the default `TypeRegistry` constructor.

## Solution

Added the missing registrations for `char` and `String`.
@bors
Copy link
Contributor

bors bot commented Feb 25, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title bevy_reflect: Add missing primitive registrations [Merged by Bors] - bevy_reflect: Add missing primitive registrations Feb 25, 2023
@bors bors bot closed this Feb 25, 2023
@MrGVSV MrGVSV deleted the reflect-primitive-registration branch February 26, 2023 00:18
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@MrGVSV @Shfty
bevy_reflect: Add missing primitive registrations (bevyengine#7815)
bb91af6 
# Objective

There were a couple primitive types missing from the default `TypeRegistry` constructor.

## Solution

Added the missing registrations for `char` and `String`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@jakobhellermann jakobhellermann jakobhellermann approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Reflection
Status: Done
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@MrGVSV @james7132 @jakobhellermann