Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Don't log a trace if EventWriter::send_batch is empty #7753

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Don't log a trace if EventWriter::send_batch is empty #7753

wants to merge 1 commit into from

Conversation

james7132
Copy link
Member

Objective

Fix #5026.

Solution

Only make a trace! log if the event count changed.

Changelog

Changed: EventWriter::send_batch will only log a TRACE level log if the batch is non-empty.

@james7132 james7132 changed the title Don't log a trace if Events::send_batch is empty Don't log a trace if EventWriter::send_batch is empty Feb 20, 2023
@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Feb 20, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 20, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 20, 2023
@james7132
Don't log a trace if EventWriter::send_batch is empty (#7753)
4e15d3d 
# Objective
Fix #5026.

## Solution
Only make a `trace!` log if the event count changed.

---

## Changelog
Changed: `EventWriter::send_batch` will only log a TRACE level log if the batch is non-empty.
@bors
Copy link
Contributor

bors bot commented Feb 20, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Don't log a trace if EventWriter::send_batch is empty [Merged by Bors] - Don't log a trace if EventWriter::send_batch is empty Feb 20, 2023
@bors bors bot closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events .send_batch makes a trace! entry even for empty insertions
3 participants
@james7132 @alice-i-cecile @mockersf