Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - create window as soon as possible #7668

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - create window as soon as possible #7668

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 14, 2023 •
edited
Loading

Objective

Solution

  • Creating the window at the end of the event loop after the resume event instead of at the beginning of the loop of the next event fixes the focus

@mockersf mockersf added A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior labels Feb 14, 2023
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Feb 14, 2023
@alice-i-cecile
Copy link
Member

@Aceeri review requested manually (since you're not in the org) :)

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 14, 2023
@mockersf
create window as soon as possible (#7668)
fae61ad 
# Objective

- Fixes #7612 
- Since #7493, windows started as unfocused

## Solution

- Creating the window at the end of the event loop after the resume event instead of at the beginning of the loop of the next event fixes the focus
@bors
Copy link
Contributor

bors bot commented Feb 14, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title create window as soon as possible [Merged by Bors] - create window as soon as possible Feb 14, 2023
@bors bors bot closed this Feb 14, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
@mockersf @myreprise1
create window as soon as possible (bevyengine#7668)
c8b1664 
# Objective

- Fixes bevyengine#7612 
- Since bevyengine#7493, windows started as unfocused

## Solution

- Creating the window at the end of the event loop after the resume event instead of at the beginning of the loop of the next event fixes the focus
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
@mockersf @myreprise1
create window as soon as possible (bevyengine#7668)
abc2760 
# Objective

- Fixes bevyengine#7612 
- Since bevyengine#7493, windows started as unfocused

## Solution

- Creating the window at the end of the event loop after the resume event instead of at the beginning of the loop of the next event fixes the focus
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
@mockersf @myreprise1
create window as soon as possible (bevyengine#7668)
7a3de82 
# Objective

- Fixes bevyengine#7612 
- Since bevyengine#7493, windows started as unfocused

## Solution

- Creating the window at the end of the event loop after the resume event instead of at the beginning of the loop of the next event fixes the focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Aceeri Aceeri Aceeri approved these changes

@maniwani maniwani Awaiting requested review from maniwani

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Regreesion: bevy:: window ::close_on_esc doesn't work correctly
3 participants
@mockersf @alice-i-cecile @Aceeri