Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bias texture mipmaps #7614

Merged
merged 16 commits into from
Jun 22, 2023
Merged

Bias texture mipmaps #7614

merged 16 commits into from
Jun 22, 2023

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Feb 10, 2023 •
edited
Loading

Objective

Solution

  • Add a MipBias component and view uniform.
  • Switch material textureSample() calls to textureSampleBias().
  • Add a -1.0 bias to TAA.

Changelog

  • Added MipBias camera component, mostly for internal use.

@JMS55 JMS55 added C-Enhancement A new feature A-Rendering Drawing game state to the screen labels Feb 10, 2023
@JMS55 JMS55 added this to the 0.10 milestone Feb 11, 2023
@JMS55 JMS55 marked this pull request as draft February 11, 2023 16:36
@JMS55 JMS55 removed this from the 0.10 milestone Feb 13, 2023
@JMS55 JMS55 added this to the 0.11 milestone Feb 23, 2023
@JMS55 JMS55 marked this pull request as ready for review April 4, 2023 04:03
@JMS55 JMS55 requested review from superdump and robtfm April 4, 2023 04:03
@JMS55 JMS55 mentioned this pull request Apr 17, 2023
Open
15 tasks
JMS55 and others added 4 commits May 1, 2023 15:24
@JMS55 @mockersf
Update crates/bevy_pbr/src/render/pbr.wgsl
f62cd85 
Co-authored-by: François <mockersf@gmail.com>
@JMS55 @mockersf
Update crates/bevy_pbr/src/render/pbr.wgsl
3174c24 
Co-authored-by: François <mockersf@gmail.com>
@JMS55 @mockersf
Update crates/bevy_pbr/src/render/pbr.wgsl
822d551 
Co-authored-by: François <mockersf@gmail.com>
@JMS55 @mockersf
Update crates/bevy_pbr/src/render/pbr.wgsl
404d346 
Co-authored-by: François <mockersf@gmail.com>
@JMS55
Copy link
Contributor Author

JMS55 commented May 1, 2023

Thanks for the fixes. Merge errors overwrote a lot of my changes by accident 😓

@cart cart enabled auto-merge June 22, 2023 20:36
@cart cart added this pull request to the merge queue Jun 22, 2023
Merged via the queue into bevyengine:main with commit 724e69b Jun 22, 2023
20 checks passed
This was referenced Jun 28, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

@IceSentry IceSentry IceSentry left review comments

@mockersf mockersf mockersf left review comments

@superdump superdump Awaiting requested review from superdump

@robtfm robtfm Awaiting requested review from robtfm

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Mipmap Biasing
4 participants
@JMS55 @cart @IceSentry @mockersf