[Merged by Bors] - Add a BackgroundColor component to TextBundle
#7596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-UI
|
Yes I'm not bothered about the builder method but it's needed while commands.spawn((
TextBundle::from_section(
"hello",
TextStyle {
font: asset_server.load("fonts/FiraSans-Bold.ttf"),
font_size: 32.0,
color: Color::WHITE
}
),
BackgroundColor(Color::NAVY)
));gives a duplicate component error. Agree about the comment. It implies that it will only set a background color for the text, when the color will fill the entire containing node. I'll change it. |
alice-i-cecile
approved these changes
Feb 10, 2023
mockersf
reviewed
Feb 10, 2023
Co-authored-by: François <mockersf@gmail.com>
MrGVSV
approved these changes
Feb 20, 2023
|
bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
# Objective `TextBundle` should have a `BackgroundColor` component. Apart from adding emphasis etc to text, adding a background color to text nodes can be extremely useful for understanding how Bevy aligns, sizes and positions text, and identifying and debugging problems. It's easy for users to insert the `BackgroundColor` component themselves but not immediately obvious or discoverable that it's possible. A `BackgroundColor` component allows us to add a `with_background_color` helper function to `TextBundle`. related issue: #5935 ## Solution Add a `BackgroundColor` component to `TextBundle`. --- ## Changelog * Added a `BackgroundColor` component to `TextBundle`. * Added a helper method `with_background_color` to `TextBundle`. ## Migration Guide `TextBundle` now has a `BackgroundColor` component. Use `TextBundle`'s `background_color` field or the `with_background_color` method to set a background color for text when spawning a text node, in place of manual insertion of a `BackgroundColor` component.
bors
bot
changed the title
BackgroundColor component to TextBundleBackgroundColor component to TextBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TextBundleshould have aBackgroundColorcomponent.Apart from adding emphasis etc to text, adding a background color to text nodes can be extremely useful for understanding how Bevy aligns, sizes and positions text, and identifying and debugging problems.
It's easy for users to insert the
BackgroundColorcomponent themselves but not immediately obvious or discoverable that it's possible. ABackgroundColorcomponent allows us to add awith_background_colorhelper function toTextBundle.related issue: #5935
Solution
Add a
BackgroundColorcomponent toTextBundle.Changelog
BackgroundColorcomponent toTextBundle.with_background_colortoTextBundle.Migration Guide
TextBundlenow has aBackgroundColorcomponent.Use
TextBundle'sbackground_colorfield or thewith_background_colormethod to set a background color for text when spawning a text node, in place of manual insertion of aBackgroundColorcomponent.