[Merged by Bors] - Allow prepass in webgl #7537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
changed the title
IceSentry
force-pushed
the
prepass-webgl
branch
from
2482062
to
f7e86a6
Compare
superdump
requested changes
Feb 7, 2023
alice-i-cecile
added
O-Web
IceSentry
force-pushed
the
prepass-webgl
branch
from
f737833
to
41466f5
Compare
|
I don't know what's going on, but this just stopped working. It worked perfectly fine when I created the PR, but it seems like I squashed a change I shouldn't have and now it stopped working. I still think we should bind the prepass textures even for webgl, but I can't get the example to work in webgl anymore. |
|
@superdump For the sake of merging this in time. I removed the changes in the example to make it work in webgl. So now all this does is some minor refactors and bind the textures in webgl when msaa is disabled. This way, we can figure out how to correctly sample the depth at a later time, but the textures will still be available for anyone to figure it out instead of being blocked by the engine. |
ciro-c
approved these changes
Feb 9, 2023
|
Please update. |
IceSentry
force-pushed
the
prepass-webgl
branch
from
5a6643e
to
7ce8000
Compare
|
@superdump updated |
IceSentry
force-pushed
the
prepass-webgl
branch
from
572e0ed
to
0033fe3
Compare
cart
approved these changes
Mar 2, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
# Objective - Use the prepass textures in webgl ## Solution - Bind the prepass textures even when using webgl, but only if msaa is disabled - Also did some refactors to centralize how textures are bound, similar to the EnvironmentMapLight PR - ~~Also did some refactors of the example to make it work in webgl~~ - ~~To make the example work in webgl, I needed to use a sampler for the depth texture, the resulting code looks a bit weird, but it's simple enough and I think it's worth it to show how it works when using webgl~~
bors
bot
changed the title
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
# Objective - Use the prepass textures in webgl ## Solution - Bind the prepass textures even when using webgl, but only if msaa is disabled - Also did some refactors to centralize how textures are bound, similar to the EnvironmentMapLight PR - ~~Also did some refactors of the example to make it work in webgl~~ - ~~To make the example work in webgl, I needed to use a sampler for the depth texture, the resulting code looks a bit weird, but it's simple enough and I think it's worth it to show how it works when using webgl~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Also did some refactors of the example to make it work in webglTo make the example work in webgl, I needed to use a sampler for the depth texture, the resulting code looks a bit weird, but it's simple enough and I think it's worth it to show how it works when using webgl