Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Val::Undefined #7485

Merged
merged 31 commits into from
Mar 13, 2023
Merged

Remove Val::Undefined #7485

merged 31 commits into from
Mar 13, 2023

Commits on Feb 2, 2023

  1. change Size default width and height to Val::Auto

    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    ea7bc05 View commit details
    Browse the repository at this point in the history

  2. changes: 

        * Removed the `Undefined` variant from `Val`.
    * Set Val's default variant to `Auto`.
    * Updated ui examples.
    * Removed `Val::Undefined` conversion code.
    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    5573ea6 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. changes: 

        * Removed the `Undefined` variant of the `Val` enum.
    * Changed `UiRect::default()` to set all fields to `Val::Px(0.0)`.
    * Added the `Inset` type that is a copy of `UiRect` but its defaults are all
        `Val::Auto`.
    * Renamed the `position` field of `Style` to `inset` and changed its type to `Inset`.
    * Updated the UI examples to remove or replace any use of `Val::Undefined`.
    * Updated the UI examples to use `Inset`.
    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    26eeca7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bevyengine:main' into main

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    78fe6ad View commit details
    Browse the repository at this point in the history

  3. Changed inset doc comments

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    b274e9e View commit details
    Browse the repository at this point in the history

  4. cargo fmt --all

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9cffde9 View commit details
    Browse the repository at this point in the history

  5. fixed UiRect doc tests

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    8ed613f View commit details
    Browse the repository at this point in the history

  6. Another Doc comment fix

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9bdf85e View commit details
    Browse the repository at this point in the history

  7. fix doc comments

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    54f68ce View commit details
    Browse the repository at this point in the history

  8. renamed Inset to Position

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    ce52876 View commit details
    Browse the repository at this point in the history

  9. cargo fmt --all

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    abdef25 View commit details
    Browse the repository at this point in the history

  10. update ui example

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5e814cf View commit details
    Browse the repository at this point in the history

  11. Removed Position struct, added its fields directly to Style

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    2087be6 View commit details
    Browse the repository at this point in the history

  12. fix doc comments

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    99b93f8 View commit details
    Browse the repository at this point in the history

  13. fix doc comment

    @ickshonpe
    ickshonpe committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5ab3ffd View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. added some simple tests

    @ickshonpe
    ickshonpe committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    eb88a97 View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @ickshonpe
    ickshonpe committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    6113911 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge branch 'main' of https://github.com/bevyengine/bevy into remove… 

    …-val-undefined
    @ickshonpe
    ickshonpe committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    cc8d6d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Merge branch 'main' of https://github.com/ickshonpe/bevy

    @ickshonpe
    ickshonpe committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    82273ec View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Changed the doc comments to be explicit about the values the helper f… 

    …unctions set to fields with no given value.
    @ickshonpe
    ickshonpe committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    431d97e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into remove-val-undefined

    @ickshonpe
    ickshonpe committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    a38647f View commit details
    Browse the repository at this point in the history

  3. fixed errors in ui example

    @ickshonpe
    ickshonpe committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    c8f200e View commit details
    Browse the repository at this point in the history

  4. fixed positions

    @ickshonpe
    ickshonpe committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    f3f02d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Removed position example from UiRect

    @ickshonpe
    ickshonpe committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5e3e7cf View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Merge branch 'main' into remove-val-undefined

    @ickshonpe
    ickshonpe committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d1c7e33 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into remove-val-undefined

    @ickshonpe
    ickshonpe committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    6215dc6 View commit details
    Browse the repository at this point in the history

  3. update convert module

    @ickshonpe
    ickshonpe committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    e72dca8 View commit details
    Browse the repository at this point in the history

  4. Fixed position in bloom_3d example

    @ickshonpe
    ickshonpe committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    29db012 View commit details
    Browse the repository at this point in the history

  5. Fixed position in bloom_2d example

    @ickshonpe
    ickshonpe committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    5cca520 View commit details
    Browse the repository at this point in the history

  6. cargo fmt

    @ickshonpe
    ickshonpe committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    51bd6df View commit details
    Browse the repository at this point in the history

  7. fix test

    @ickshonpe
    ickshonpe committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9369aa1 View commit details
    Browse the repository at this point in the history