Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Size::height sets width not height #7478

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - Size::height sets width not height #7478

wants to merge 10 commits into from

Commits on Feb 2, 2023

  1. changes: 

        * added `width`, `height`, and `all` const functions to `Size`
    * added the constant `Size::FILL`, a `Size` with width and height set to `Val::Percent(100.0)`
    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1cf29a6 View commit details
    Browse the repository at this point in the history

  2. removed the Size::FILL constant

    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    7f184c2 View commit details
    Browse the repository at this point in the history

  3. removed Size::ALL from example

    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0de482a View commit details
    Browse the repository at this point in the history

  4. removed Size::Fill from example

    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    9160795 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'size-helper-functions' of https://github.com/ickshonpe/… 

    …bevy into size-helper-functions
    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    83ddb7a View commit details
    Browse the repository at this point in the history

  6. change Size default width and height to Val::Auto

    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    ea7bc05 View commit details
    Browse the repository at this point in the history

  7. The Size::height function was setting the width, not the height to th… 

    …e given value. Fixed it so it sets the value for height.
    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    403cb65 View commit details
    Browse the repository at this point in the history

  8. changes: 

        * added `width`, `height`, and `all` const functions to `Size`
    * added the constant `Size::FILL`, a `Size` with width and height set to `Val::Percent(100.0)`
    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    9c8c077 View commit details
    Browse the repository at this point in the history

  9. The Size::height function was setting the width, not the height to th… 

    …e given value. Fixed it so it sets the value for height.
    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    f5524c2 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'size-helper-functions' of https://github.com/ickshonpe/… 

    …bevy into size-helper-functions
    @ickshonpe
    ickshonpe committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    a74d7a5 View commit details
    Browse the repository at this point in the history