Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove unnecessary Default impl of HandleType #7472

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove unnecessary Default impl of HandleType #7472

wants to merge 1 commit into from

Conversation

MinerSebas
Copy link
Contributor

Objective

  • Resolve a Fixme to remove the Default impl for HandleType, once Reflection no longer requires it.
  • Presumebly this Comment was made before the FromReflect Derive used the #[reflect(Default)], to substitute for the requirment that a ignored field has a Default.

Solution

  • Just remove the Default derive and comment.

@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change A-Reflection Runtime information about types S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 2, 2023
@alice-i-cecile
Copy link
Member

Can you update the PR title to better describe what was done?

@MinerSebas MinerSebas changed the title Resolve Fixme in bevy_asset Remove unnecessary Default impl of HandleType Feb 2, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 2, 2023
@MinerSebas
Remove unnecessary Default impl of HandleType (#7472)
1a18ab3 
# Objective

- Resolve a Fixme to remove the `Default` impl for `HandleType`, once Reflection no longer requires it.
- Presumebly this Comment was made before the `FromReflect` Derive used the `#[reflect(Default)]`, to substitute for the requirment that a ignored field has a `Default`.

## Solution

- Just remove the `Default` derive and comment.
@bors
Copy link
Contributor

bors bot commented Feb 2, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove unnecessary Default impl of HandleType [Merged by Bors] - Remove unnecessary Default impl of HandleType Feb 2, 2023
@bors bors bot closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinerSebas @alice-i-cecile @mockersf