Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Derive FromReflect for Aabb #7396

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Derive FromReflect for Aabb #7396

wants to merge 1 commit into from

Conversation

djeedai
Copy link
Contributor

@djeedai djeedai commented Jan 28, 2023

Objective

Add a FromReflect derive to the Aabb type, like all other math types, so we can reflect Vec<Aabb>.

Solution

Just add it :)

Changelog

Added

  • Implemented FromReflect for Aabb.

@djeedai
Derive FromReflect for Aabb
5f33367 
Add a `FromReflect` derive to the `Aabb` type, like all other math
types, so we can reflect `Vec<Aabb>`.
@djeedai djeedai added A-Rendering Drawing game state to the screen A-Reflection Runtime information about types A-Math Fundamental domain-agnostic mathematical operations C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jan 28, 2023
superdump
superdump approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Jan 30, 2023
@djeedai
Derive FromReflect for Aabb (#7396)
a61bf35 
# Objective

Add a `FromReflect` derive to the `Aabb` type, like all other math types, so we can reflect `Vec<Aabb>`.

## Solution

Just add it :)

---

## Changelog

### Added

- Implemented `FromReflect` for `Aabb`.
@bors
Copy link
Contributor

bors bot commented Jan 30, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Derive FromReflect for Aabb [Merged by Bors] - Derive FromReflect for Aabb Jan 30, 2023
@bors bors bot closed this Jan 30, 2023
@djeedai djeedai deleted the aabb-from-reflect branch January 30, 2023 09:06
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@djeedai @ItsDoot
Derive FromReflect for Aabb (bevyengine#7396)
08d243b 
# Objective

Add a `FromReflect` derive to the `Aabb` type, like all other math types, so we can reflect `Vec<Aabb>`.

## Solution

Just add it :)

---

## Changelog

### Added

- Implemented `FromReflect` for `Aabb`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@james7132 james7132 james7132 approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Reflection Runtime information about types A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djeedai @superdump @james7132 @tim-blackbird