Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix overflow scaling for images #7142

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix overflow scaling for images #7142

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 9, 2023

Objective

@mockersf mockersf mentioned this pull request Jan 9, 2023
Closed
@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Jan 9, 2023
rparrett
rparrett approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested image and text clipping at various scale factors.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 9, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 9, 2023
@mockersf
Fix overflow scaling for images (#7142)
470341d 
# Objective

- Fixes #4057 
- Do not multiply position by scale factor
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 9, 2023
@mockersf
Fix overflow scaling for images (#7142)
9be47e3 
# Objective

- Fixes #4057 
- Do not multiply position by scale factor
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix overflow scaling for images [Merged by Bors] - Fix overflow scaling for images Jan 9, 2023
@bors bors bot closed this Jan 9, 2023
james7132 pushed a commit to james7132/bevy that referenced this pull request Jan 21, 2023
@mockersf @james7132
Fix overflow scaling for images (bevyengine#7142)
1246fdf 
# Objective

- Fixes bevyengine#4057 
- Do not multiply position by scale factor
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@mockersf @alradish
Fix overflow scaling for images (bevyengine#7142)
1ccfe7a 
# Objective

- Fixes bevyengine#4057 
- Do not multiply position by scale factor
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
Fix overflow scaling for images (bevyengine#7142)
b12c4ad 
# Objective

- Fixes bevyengine#4057 
- Do not multiply position by scale factor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distortion at the edges of an Overflow::Hidden UI node
3 participants
@mockersf @alice-i-cecile @rparrett