Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix a miscompilation with #[derive(SystemParam)] #7105

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix a miscompilation with #[derive(SystemParam)] #7105

wants to merge 2 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Jan 6, 2023

Objective

Solution

  • Add the where clause.

@JoJoJet JoJoJet changed the title System param where clause Fix a miscompilation with #[derive(SystemParam)] Jan 6, 2023
@JoJoJet JoJoJet added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events labels Jan 6, 2023
@iiYese
Copy link
Contributor

iiYese commented Jan 6, 2023

I think it would be a good idea to add a where clause compile test to the unit tests so this doesn't go unnoticed in future.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 6, 2023
@JoJoJet
Copy link
Member Author

JoJoJet commented Jan 6, 2023

I think it would be a good idea to add a where clause compile test to the unit tests so this doesn't go unnoticed in future.

This is already included in this PR.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 10, 2023
@JoJoJet
Fix a miscompilation with #[derive(SystemParam)] (#7105)
d92d5e7 
# Objective

- Fix #7103.
- The issue is caused because I forgot to add a where clause to a generated struct in #7056.

## Solution

- Add the where clause.
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 10, 2023
@JoJoJet
Fix a miscompilation with #[derive(SystemParam)] (#7105)
dfd453b 
# Objective

- Fix #7103.
- The issue is caused because I forgot to add a where clause to a generated struct in #7056.

## Solution

- Add the where clause.
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 10, 2023
@JoJoJet
Fix a miscompilation with #[derive(SystemParam)] (#7105)
fa40e2b 
# Objective

- Fix #7103.
- The issue is caused because I forgot to add a where clause to a generated struct in #7056.

## Solution

- Add the where clause.
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix a miscompilation with #[derive(SystemParam)] [Merged by Bors] - Fix a miscompilation with #[derive(SystemParam)] Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
@JoJoJet JoJoJet deleted the system-param-where-clause branch January 13, 2023 02:29
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@JoJoJet @alradish
Fix a miscompilation with #[derive(SystemParam)] (bevyengine#7105)
081a23c 
# Objective

- Fix bevyengine#7103.
- The issue is caused because I forgot to add a where clause to a generated struct in bevyengine#7056.

## Solution

- Add the where clause.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@JoJoJet @ItsDoot
Fix a miscompilation with #[derive(SystemParam)] (bevyengine#7105)
f6df3e9 
# Objective

- Fix bevyengine#7103.
- The issue is caused because I forgot to add a where clause to a generated struct in bevyengine#7056.

## Solution

- Add the where clause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGMossa CGMossa CGMossa approved these changes

@james7132 james7132 james7132 approved these changes

@Guvante Guvante Guvante approved these changes

@mockersf mockersf mockersf approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SystemParam derive inconsistent with where clauses.
8 participants
@JoJoJet @iiYese @alice-i-cecile @CGMossa @james7132 @Guvante @mockersf @tim-blackbird