Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - improve nix docs #7044

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - improve nix docs #7044

wants to merge 1 commit into from

Conversation

figsoda
Copy link
Contributor

@figsoda figsoda commented Dec 28, 2022

Objective

xlibsWrapper is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

Solution

  • rename NixOS to Nix since this is not specific to NixOS
  • remove usage of xlibsWrapper
  • add instructions for nix flakes with nix develop
  • add example of a packaged bevy program in nixpkgs
  • minor cosmetic/grammatical changes

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation O-Linux Specific to the Linux desktop operating system labels Dec 28, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As is conventional for this file, this is basically a "this is clear and free of obvious mistakes" not, "I have verified this personally" :)

@james7132
Copy link
Member

I do, however, find it exceptionally alarming that Nix(OS) has been updated at this cadence. Not sure what is going on, but the rate at which these edits are coming seems to outpace even the dependency churn rate for Bevy as a whole.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 28, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 29, 2022
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
@bors bors bot changed the title improve nix docs [Merged by Bors] - improve nix docs Dec 29, 2022
@bors bors bot closed this Dec 29, 2022
@figsoda figsoda deleted the docs branch December 29, 2022 21:55
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Docs An addition or correction to our documentation O-Linux Specific to the Linux desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants