[Merged by Bors] - Use bevy with default features in iOS example
#7042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Dec 27, 2022
|
Thanks for testing and the fix! |
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
requested changes
Dec 28, 2022
alice-i-cecile
removed
the
S-Ready-For-Final-Review
* It's fixes a bug related to a missing ```asset``` in a ```text_system```
|
Awesome, if this works can you update the PR description and title? bors try |
mockersf
approved these changes
Dec 28, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 28, 2022
# Objective I am new to Bevy. And during my development, I noticed that the `iOS` example doesn't work. Example panics with next message: ```panicked at 'Resource requested by bevy_ui::widget::text::text_system does not exist: bevy_asset::assets::Assets```. I have asked for help in a `discord` iOS chat and there I receive a recommendation that it is possible that some bevy features missing. ## Solution So, I added a ```bevy_sprite``` and it fixes the problem :)
|
bors r- |
|
Canceled. |
|
Waiting a bit so @silvestrpredko has a chance to update the PR title :) |
silvestrpredko
changed the title
bevy_sprite in iOS examplebevy with default features in iOS example
Done, sorry for the delay. I miss updating a PR title. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 28, 2022
# Objective I am new to Bevy. And during my development, I noticed that the `iOS` example doesn't work. Example panics with next message: ```panicked at 'Resource requested by bevy_ui::widget::text::text_system does not exist: bevy_asset::assets::Assets```. I have asked for help in a `discord` iOS chat and there I receive a recommendation that it is possible that some bevy features missing. ## Solution So, I used ```bevy``` with default features.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
bevy with default features in iOS examplebevy with default features in iOS example
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective I am new to Bevy. And during my development, I noticed that the `iOS` example doesn't work. Example panics with next message: ```panicked at 'Resource requested by bevy_ui::widget::text::text_system does not exist: bevy_asset::assets::Assets```. I have asked for help in a `discord` iOS chat and there I receive a recommendation that it is possible that some bevy features missing. ## Solution So, I used ```bevy``` with default features.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective I am new to Bevy. And during my development, I noticed that the `iOS` example doesn't work. Example panics with next message: ```panicked at 'Resource requested by bevy_ui::widget::text::text_system does not exist: bevy_asset::assets::Assets```. I have asked for help in a `discord` iOS chat and there I receive a recommendation that it is possible that some bevy features missing. ## Solution So, I used ```bevy``` with default features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I am new to Bevy. And during my development, I noticed that the
iOSexample doesn't work.Example panics with next message:
panicked at 'Resource requested by bevy_ui::widget::text::text_system does not exist: bevy_asset::assets::Assets.I have asked for help in a
discordiOS chat and there I receive a recommendation that it is possible that some bevy features missing.Solution
So, I used
bevywith default features.