[Merged by Bors] - Apply WindowDescriptor settings in all modes
#6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hymm
approved these changes
Dec 12, 2022
NiklasEi
reviewed
Dec 12, 2022
IceSentry
reviewed
Dec 12, 2022
| if let Some(sf) = scale_factor_override { | ||
| winit_window_builder.with_inner_size(logical_size.to_physical::<f64>(sf)) | ||
| } else { | ||
| winit_window_builder.with_inner_size(logical_size) | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| winit_window_builder = winit_window_builder |
There was a problem hiding this comment.
I guess it's not an issue, but it seems to me like most of those settings simply won't do anything when not in windowed mode
There was a problem hiding this comment.
always_on_top and transparent work in all modes.
The resizable and decorations settings will still take effect if the window is switched to windowed mode later on.
There was a problem hiding this comment.
Ah, right, didn't think about switching mode, makes sense.
Good question :) |
IceSentry
approved these changes
Dec 12, 2022
hymm
added
C-Bug
mockersf
approved these changes
Dec 12, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
# Objective Some settings were only applied in windowed mode. Fix the issue in #6933 # Solution Always apply the settings. Co-authored-by: devil-ira <justthecooldude@gmail.com>
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
WindowDescriptor settings in all modesWindowDescriptor settings in all modes
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective Some settings were only applied in windowed mode. Fix the issue in bevyengine#6933 # Solution Always apply the settings. Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Some settings were only applied in windowed mode. Fix the issue in bevyengine#6933 # Solution Always apply the settings. Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Some settings were only applied in windowed mode.
Fix the issue in #6933
Solution
Always apply the settings.