[Merged by Bors] - Rename camera "priority" to "order" #6908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
approved these changes
Dec 10, 2022
alice-i-cecile
added
C-Docs
alice-i-cecile
approved these changes
Dec 11, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
It's actually "lower number = higher priority", e.g. There current docs are correct, but easy to misinterpret. I think a more verbose explanation is needed. Feel free to yoink the first paragraph of this comment :) |
|
I thought it would be that way given the docs, but the behavior I've seen from messing around is higher number is higher priority |
|
Ohhh, never mind I understand, yeah I was very confused by that. |
alice-i-cecile
removed
the
S-Ready-For-Final-Review
|
Maybe it should be renamed to |
Aceeri
force-pushed
the
priority-docs
branch
from
57da04c
to
5fab697
Compare
Aceeri
changed the title
Aceeri
changed the title
alice-i-cecile
approved these changes
Dec 24, 2022
alice-i-cecile
added
S-Ready-For-Final-Review
|
This is a breaking change, and will need a simple migration guide entry. @Aceeri, ideally you can add that to your PR description. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective The documentation for camera priority is very confusing at the moment, it requires a bit of "double negative" kind of thinking. # Solution Flipping the wording on the documentation to reflect more common usecases like having an overlay camera and also renaming it to "order", since priority implies that it will override the other camera rather than have both run.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective The documentation for camera priority is very confusing at the moment, it requires a bit of "double negative" kind of thinking. # Solution Flipping the wording on the documentation to reflect more common usecases like having an overlay camera and also renaming it to "order", since priority implies that it will override the other camera rather than have both run.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective The documentation for camera priority is very confusing at the moment, it requires a bit of "double negative" kind of thinking. # Solution Flipping the wording on the documentation to reflect more common usecases like having an overlay camera and also renaming it to "order", since priority implies that it will override the other camera rather than have both run.
bors
bot
changed the title
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective The documentation for camera priority is very confusing at the moment, it requires a bit of "double negative" kind of thinking. # Solution Flipping the wording on the documentation to reflect more common usecases like having an overlay camera and also renaming it to "order", since priority implies that it will override the other camera rather than have both run.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective The documentation for camera priority is very confusing at the moment, it requires a bit of "double negative" kind of thinking. # Solution Flipping the wording on the documentation to reflect more common usecases like having an overlay camera and also renaming it to "order", since priority implies that it will override the other camera rather than have both run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The documentation for camera priority is very confusing at the moment, it requires a bit of "double negative" kind of thinking.
Solution
Flipping the wording on the documentation to reflect more common usecases like having an overlay camera and also renaming it to "order", since priority implies that it will override the other camera rather than have both run.
Changelog
Migration
prioritytoorderin usage ofCamera.