Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - scene viewer: can select a scene from the asset path #6859

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - scene viewer: can select a scene from the asset path #6859

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 5, 2022

Objective

Solution

  • Can select which scene to display using #SceneN, defaults to scene 0 if not present
  • Display the number of scenes available if there are more than one

@mockersf mockersf added the C-Examples An addition or correction to our examples label Dec 5, 2022
@james7132 james7132 added the A-Scenes Serialized ECS data stored on the disk label Dec 6, 2022
@mockersf @tim-blackbird
wording
76330ba 
Co-authored-by: ira <JustTheCoolDude@gmail.com>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 11, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 11, 2022
@mockersf
scene viewer: can select a scene from the asset path (#6859)
f4818bc 
# Objective

- Fixes #6630, fixes #6679
- Improve scene viewer in cases where there are more than one scene in a gltf file

## Solution

- Can select which scene to display using `#SceneN`, defaults to scene 0 if not present
- Display the number of scenes available if there are more than one
@bors
Copy link
Contributor

bors bot commented Dec 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title scene viewer: can select a scene from the asset path [Merged by Bors] - scene viewer: can select a scene from the asset path Dec 11, 2022
@bors bors bot closed this Dec 11, 2022
@james7132 james7132 added this to the 0.10 milestone Dec 12, 2022
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@mockersf @alradish
scene viewer: can select a scene from the asset path (bevyengine#6859)
c0a68c0 
# Objective

- Fixes bevyengine#6630, fixes bevyengine#6679
- Improve scene viewer in cases where there are more than one scene in a gltf file

## Solution

- Can select which scene to display using `#SceneN`, defaults to scene 0 if not present
- Display the number of scenes available if there are more than one
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
scene viewer: can select a scene from the asset path (bevyengine#6859)
2dbecdb 
# Objective

- Fixes bevyengine#6630, fixes bevyengine#6679
- Improve scene viewer in cases where there are more than one scene in a gltf file

## Solution

- Can select which scene to display using `#SceneN`, defaults to scene 0 if not present
- Display the number of scenes available if there are more than one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@HoNile HoNile HoNile approved these changes

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Gltf scene is not properly rendered. scene_viewer is crashed when loading gltf.
5 participants
@mockersf @alice-i-cecile @tim-blackbird @HoNile @james7132