[Merged by Bors] - Intepret glTF colors as linear instead of sRGB #6828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Dec 2, 2022
mockersf
approved these changes
Dec 2, 2022
mockersf
added
the
S-Ready-For-Final-Review
|
Good catch! I noticed this during the last game jam but then completely forgot about it. I think it would be good to make sure that a change like this has really good discoverability in the migration guide as it will totally change the look of any GLTF assets that use colors. This could be really unexpected and confusing for people since they would have already authored art excepting colors to look a certain way. Unfortunately without the proper asset pipeline features, this could be difficult for users to programmatically correct. Hopefully that asset features are in place for 0.10 that can make this type of fix easy to deal with. |
alice-i-cecile
added
the
C-Breaking-Change
|
Breaking change label added to make sure this is picked up in the migration guide :) Good call out @DGriffin91 |
superdump
approved these changes
Dec 4, 2022
bors bot
pushed a commit
that referenced
this pull request
Dec 4, 2022
# Objective Fixes #6827 ## Solution Use the `Color::rgba_linear` function instead of the `Color::rgba` function to correctly interpret colors from glTF files in the linear color space rather than the incorrect sRGB color space
bors
bot
changed the title
ickshonpe
pushed a commit
to ickshonpe/bevy
that referenced
this pull request
Dec 6, 2022
# Objective Fixes bevyengine#6827 ## Solution Use the `Color::rgba_linear` function instead of the `Color::rgba` function to correctly interpret colors from glTF files in the linear color space rather than the incorrect sRGB color space
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective Fixes bevyengine#6827 ## Solution Use the `Color::rgba_linear` function instead of the `Color::rgba` function to correctly interpret colors from glTF files in the linear color space rather than the incorrect sRGB color space
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#6827 ## Solution Use the `Color::rgba_linear` function instead of the `Color::rgba` function to correctly interpret colors from glTF files in the linear color space rather than the incorrect sRGB color space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #6827
Solution
Use the
Color::rgba_linearfunction instead of theColor::rgbafunction to correctly interpret colors from glTF files in the linear color space rather than the incorrect sRGB color space