[Merged by Bors] - Make Core Pipeline Graph Nodes Public #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-Rendering
alice-i-cecile
approved these changes
Nov 14, 2022
mockersf
reviewed
Nov 14, 2022
Comment on lines
-178
to
+165
| const IN_VIEW: &'static str = "view"; | ||
| pub const IN_VIEW: &'static str = "view"; |
There was a problem hiding this comment.
if this is going to be public and reused, should it have a more unique value?
There was a problem hiding this comment.
I'm not sure if this is in the scope of this PR, currently other core nodes all have the same input slot name.
There was a problem hiding this comment.
I think it makes sense that the input slots have the same name if they serve the same purpose for their respective nodes.
komadori
approved these changes
Nov 14, 2022
ickk
approved these changes
Nov 16, 2022
james7132
added
the
S-Ready-For-Final-Review
…ipeline-nodes-public
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
# Objective Make core pipeline graphic nodes, including `BloomNode`, `FxaaNode`, `TonemappingNode` and `UpscalingNode` public. This will allow users to construct their own render graphs with these build-in nodes. ## Solution Make them public. Also put node names into bevy's core namespace (`core_2d::graph::node`, `core_3d::graph::node`) which makes them consistent.
bors
bot
changed the title
cart
pushed a commit
that referenced
this pull request
Nov 30, 2022
# Objective Make core pipeline graphic nodes, including `BloomNode`, `FxaaNode`, `TonemappingNode` and `UpscalingNode` public. This will allow users to construct their own render graphs with these build-in nodes. ## Solution Make them public. Also put node names into bevy's core namespace (`core_2d::graph::node`, `core_3d::graph::node`) which makes them consistent.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Make core pipeline graphic nodes, including `BloomNode`, `FxaaNode`, `TonemappingNode` and `UpscalingNode` public. This will allow users to construct their own render graphs with these build-in nodes. ## Solution Make them public. Also put node names into bevy's core namespace (`core_2d::graph::node`, `core_3d::graph::node`) which makes them consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make core pipeline graphic nodes, including
BloomNode,FxaaNode,TonemappingNodeandUpscalingNodepublic.This will allow users to construct their own render graphs with these build-in nodes.
Solution
Make them public.
Also put node names into bevy's core namespace (
core_2d::graph::node,core_3d::graph::node) which makes them consistent.