Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use wgsl saturate #6318

Closed

Conversation

torsteingrindvik
Copy link
Contributor

Objective

Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl.

naga's version allows usage for not only scalars but vectors as well.

Solution

Remove the utils.wgsl saturate function.

Changelog

Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.

# Objective

Use saturate wgsl function now implemented in naga (version 0.10.0).
There is now no need for one in utils.wgsl.

naga's version allows usage for not only scalars but vectors as well.

## Solution

Remove the utils.wgsl saturate function.

## Changelog

Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.

Signed-off-by: Torstein Grindvik <torstein.grindvik@nordicsemi.no>
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Oct 20, 2022
@alice-i-cecile
Copy link
Member

Doesn't appear to be in the changelog, but I can verify its existence in the code.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 20, 2022
@rparrett
Copy link
Contributor

rparrett commented Oct 20, 2022

Doesn't appear to be in the changelog, but I can verify its existence in the code.

Third item in the changelog.

I think that CI would have caught that.

I did test the lighting example (and on wasm) just for good measure.

@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 22, 2022
# Objective

Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl.

naga's version allows usage for not only scalars but vectors as well.

## Solution

Remove the utils.wgsl saturate function.

## Changelog

Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.
@bors bors bot changed the title Use wgsl saturate [Merged by Bors] - Use wgsl saturate Oct 22, 2022
@bors bors bot closed this Oct 22, 2022
@torsteingrindvik torsteingrindvik deleted the use-naga-saturate branch October 22, 2022 09:16
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl.

naga's version allows usage for not only scalars but vectors as well.

## Solution

Remove the utils.wgsl saturate function.

## Changelog

Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
# Objective

Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl.

naga's version allows usage for not only scalars but vectors as well.

## Solution

Remove the utils.wgsl saturate function.

## Changelog

Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl.

naga's version allows usage for not only scalars but vectors as well.

## Solution

Remove the utils.wgsl saturate function.

## Changelog

Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants