Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add missing type registrations for bevy_math types #5758

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add missing type registrations for bevy_math types #5758

wants to merge 1 commit into from

Conversation

inodentry
Copy link
Contributor

Type registrations were only present for some of the bevy_math types, and missing for others. This is a very strange inconsistency, given that they all impl Reflect and FromReflect. In practice, this means these types cannot be used in scenes.

In particular, this is especially problematic, because Affine3A is one of the missing types, and it is now used in GlobalTransform. Trying to create a bevy scene that contains GlobalTransforms results in an error due to the missing type registration.

@inodentry inodentry added C-Bug An unexpected or incorrect behavior A-Core Common functionality for all bevy apps A-Reflection Runtime information about types labels Aug 21, 2022
@MrGVSV MrGVSV added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 21, 2022
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 23, 2022
Type registrations were only present for some of the `bevy_math` types, and missing for others. This is a very strange inconsistency, given that they all impl `Reflect` and `FromReflect`. In practice, this means these types cannot be used in scenes.

In particular, this is especially problematic, because `Affine3A` is one of the missing types, and it is now used in `GlobalTransform`. Trying to create a bevy scene that contains `GlobalTransform`s results in an error due to the missing type registration.
@bors bors bot changed the title Add missing type registrations for bevy_math types [Merged by Bors] - Add missing type registrations for bevy_math types Aug 23, 2022
@bors bors bot closed this Aug 23, 2022
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
Type registrations were only present for some of the `bevy_math` types, and missing for others. This is a very strange inconsistency, given that they all impl `Reflect` and `FromReflect`. In practice, this means these types cannot be used in scenes.

In particular, this is especially problematic, because `Affine3A` is one of the missing types, and it is now used in `GlobalTransform`. Trying to create a bevy scene that contains `GlobalTransform`s results in an error due to the missing type registration.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
Type registrations were only present for some of the `bevy_math` types, and missing for others. This is a very strange inconsistency, given that they all impl `Reflect` and `FromReflect`. In practice, this means these types cannot be used in scenes.

In particular, this is especially problematic, because `Affine3A` is one of the missing types, and it is now used in `GlobalTransform`. Trying to create a bevy scene that contains `GlobalTransform`s results in an error due to the missing type registration.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
Type registrations were only present for some of the `bevy_math` types, and missing for others. This is a very strange inconsistency, given that they all impl `Reflect` and `FromReflect`. In practice, this means these types cannot be used in scenes.

In particular, this is especially problematic, because `Affine3A` is one of the missing types, and it is now used in `GlobalTransform`. Trying to create a bevy scene that contains `GlobalTransform`s results in an error due to the missing type registration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core Common functionality for all bevy apps A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants