Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Derive AsBindGroup Improvements: Better errors, more options, update examples #5364

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Derive AsBindGroup Improvements: Better errors, more options, update examples #5364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e9a961d
better errors, support more options via name-value pairs in texture a…
wrapperup Jul 18, 2022
38fdaf9
update array_texture example to use AsBindGroup derive macro
wrapperup Jul 18, 2022
5ef96c5
run cargo fmt
wrapperup Jul 18, 2022
57c0e6a
remove unused `binding` constant and imports
wrapperup Jul 18, 2022
72d6cb4
organize code, split out parsing, use Parse trait
wrapperup Jul 18, 2022
8501230
support visibility, use ToTokens for attr args instead of quoting in …
wrapperup Jul 18, 2022
042077b
fix wrong symbol name for visibility
wrapperup Jul 18, 2022
f65f88d
proper hygiene for visibility flag, lowercased flags
wrapperup Jul 19, 2022
2fadaaf
don't error on non-ident attribute paths
wrapperup Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crates/bevy_macro_utils/src/attrs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,17 @@ pub fn get_lit_str(attr_name: Symbol, lit: &syn::Lit) -> syn::Result<&syn::LitSt
))
}
}

pub fn get_lit_bool(attr_name: Symbol, lit: &syn::Lit) -> syn::Result<bool> {
if let syn::Lit::Bool(lit) = lit {
Ok(lit.value())
} else {
Err(syn::Error::new_spanned(
lit,
format!(
"expected {} attribute to be a bool value, `true` or `false`: `{} = ...`",
attr_name, attr_name
),
))
}
}
Loading