Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Rename headless_defaults example to no_renderer for clarity #5263

Closed
wants to merge 2 commits into from

Conversation

LegNeato
Copy link
Contributor

@LegNeato LegNeato commented Jul 9, 2022

Objective

Solution

  • Rename the example and add to the docs that the window is expected.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer!

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jul 9, 2022
@LegNeato
Copy link
Contributor Author

LegNeato commented Jul 9, 2022

Will fix CI in a bit

@alice-i-cecile
Copy link
Member

@Shatur @DJMcNab, please review when you get a chance :)

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 10, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 11, 2022
# Objective

- Reduce confusion as the example opens a window and isn't truly "headless"
- Fixes #5260.


## Solution

- Rename the example and add to the docs that the window is expected.
@bors bors bot changed the title Rename headless_defaults example to no_renderer for clarity [Merged by Bors] - Rename headless_defaults example to no_renderer for clarity Jul 11, 2022
@bors bors bot closed this Jul 11, 2022
@LegNeato LegNeato deleted the headless_example_new branch July 12, 2022 20:28
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
…engine#5263)

# Objective

- Reduce confusion as the example opens a window and isn't truly "headless"
- Fixes bevyengine#5260.


## Solution

- Rename the example and add to the docs that the window is expected.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…engine#5263)

# Objective

- Reduce confusion as the example opens a window and isn't truly "headless"
- Fixes bevyengine#5260.


## Solution

- Rename the example and add to the docs that the window is expected.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…engine#5263)

# Objective

- Reduce confusion as the example opens a window and isn't truly "headless"
- Fixes bevyengine#5260.


## Solution

- Rename the example and add to the docs that the window is expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

headless_defaults example displays an empty window
6 participants