Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add support for removing attributes from meshes. #5254

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Add support for removing attributes from meshes. #5254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d6f822
Add Mesh::remove_attribute().
komadori Jul 8, 2022
6886a57
Change remove_attribute to use Into<MeshVertexAttributeId>.
komadori Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crates/bevy_render/src/mesh/mesh/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,16 @@ impl Mesh {
);
}

/// Removes the data for a vertex attribute
pub fn remove_attribute(
&mut self,
attribute: impl Into<MeshVertexAttributeId>,
) -> Option<VertexAttributeValues> {
self.attributes
.remove(&attribute.into())
.map(|data| data.values)
}

#[inline]
pub fn contains_attribute(&self, id: impl Into<MeshVertexAttributeId>) -> bool {
self.attributes.contains_key(&id.into())
Expand Down