Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_reflect: fix broken test #5196

Closed
wants to merge 1 commit into from
Closed

bevy_reflect: fix broken test #5196

wants to merge 1 commit into from

Conversation

jakobhellermann
Copy link
Contributor

Objective

  • cargo test -p bevy_reflect --features glam fails, since 12.0 now (?) serializes to just 12

Solution

  • update the serialization snapshot

@jakobhellermann jakobhellermann added A-Reflection Runtime information about types C-Testing A change that impacts how we test Bevy or how users test their apps labels Jul 4, 2022
alice-i-cecile
alice-i-cecile approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other PR; I'm going to let this sit for a bit but I'm comfortable merging this unilaterally.

@mockersf
Copy link
Member

mockersf commented Jul 4, 2022 •
edited
Loading

I think this will fail CI: did you update your dependencies locally?
Same issue was encountered in #5142

@jakobhellermann
Copy link
Contributor Author

Weird. Since Vec3 isn't reflect_value and f32 is, this should come down to impl Serialize for f32. Why this is different in CI and my local setup I have no idea.

@mockersf
Copy link
Member

mockersf commented Jul 4, 2022

Why this is different in CI and my local setup I have no idea.

running cargo update should fix it for you

@jakobhellermann jakobhellermann deleted the bevy-reflect-fix-test branch July 4, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Testing A change that impacts how we test Bevy or how users test their apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakobhellermann @mockersf @alice-i-cecile