Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Rename Color::as_hlsa_f32 to Color::as_hsla_f32 #4827

Closed

Conversation

NiklasEi
Copy link
Member

Objective

Make the function consistent with returned values and as_hsla method

Fixes #4826

Solution

  • Rename the method

Migration Guide

  • Rename the method

@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels May 22, 2022
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 23, 2022
# Objective

Make the function consistent with returned values and `as_hsla` method

Fixes #4826 

## Solution

- Rename the method


## Migration Guide

- Rename the method
@bors
Copy link
Contributor

bors bot commented May 23, 2022

Build failed:

ManevilleF pushed a commit to ManevilleF/bevy that referenced this pull request May 25, 2022
# Objective

Make the function consistent with returned values and `as_hsla` method

Fixes bevyengine#4826 

## Solution

- Rename the method


## Migration Guide

- Rename the method
@james7132
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request May 25, 2022
# Objective

Make the function consistent with returned values and `as_hsla` method

Fixes #4826 

## Solution

- Rename the method


## Migration Guide

- Rename the method
@bors bors bot changed the title Rename Color::as_hlsa_f32 to Color::as_hsla_f32 [Merged by Bors] - Rename Color::as_hlsa_f32 to Color::as_hsla_f32 May 25, 2022
@bors bors bot closed this May 25, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Jun 7, 2022
# Objective

Make the function consistent with returned values and `as_hsla` method

Fixes bevyengine#4826 

## Solution

- Rename the method


## Migration Guide

- Rename the method
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Make the function consistent with returned values and `as_hsla` method

Fixes bevyengine#4826 

## Solution

- Rename the method


## Migration Guide

- Rename the method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color::as_hlsa_f32 returns component in wrong order.
5 participants