[Merged by Bors] - Add missing audio/ogg file extensions: .oga, .spx #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CleanCut
changed the title
mockersf
approved these changes
May 9, 2022
CleanCut
added a commit
to CleanCut/rusty_engine
that referenced
this pull request
May 9, 2022
alice-i-cecile
added
C-Enhancement
alice-i-cecile
approved these changes
May 9, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
# Objective - Add two missing ogg vorbis audio extensions. ## Solution - Add the two missing extensions to the list - The file format is the same, there are simply two other possible extensions files can use. - This can be easily (manually) tested by renaming the extension of `assets/sounds/Windless Slopes.ogg` to end in either `.oga` or `.spx` (in both the filesystem and in `examples/audio/audio.rs`) and then running `cargo run --example audio` and observing that the music still plays. ## More info From the [wikipedia article for Ogg](https://en.wikipedia.org/wiki/Ogg): > Ogg audio media is registered as [IANA](https://en.wikipedia.org/wiki/Internet_Assigned_Numbers_Authority) [media type](https://en.wikipedia.org/wiki/Media_type) audio/ogg with file extensions .oga, .ogg, and [.spx](https://en.wikipedia.org/wiki/Speex). The current workaround is to rename any files ending in `.oga` or `.spx` to end in `.ogg` instead, which complicates tracking assets procured from other organizations. See also [a corresponding change to bevy_kira_audio](NiklasEi/bevy_kira_audio#8) --- ## Changelog ### Added - Vorbis audio files may now use the `.oga` and `.spx` filename extensions in addition to the more common `.ogg` filename extension.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
# Objective - Add two missing ogg vorbis audio extensions. ## Solution - Add the two missing extensions to the list - The file format is the same, there are simply two other possible extensions files can use. - This can be easily (manually) tested by renaming the extension of `assets/sounds/Windless Slopes.ogg` to end in either `.oga` or `.spx` (in both the filesystem and in `examples/audio/audio.rs`) and then running `cargo run --example audio` and observing that the music still plays. ## More info From the [wikipedia article for Ogg](https://en.wikipedia.org/wiki/Ogg): > Ogg audio media is registered as [IANA](https://en.wikipedia.org/wiki/Internet_Assigned_Numbers_Authority) [media type](https://en.wikipedia.org/wiki/Media_type) audio/ogg with file extensions .oga, .ogg, and [.spx](https://en.wikipedia.org/wiki/Speex). The current workaround is to rename any files ending in `.oga` or `.spx` to end in `.ogg` instead, which complicates tracking assets procured from other organizations. See also [a corresponding change to bevy_kira_audio](NiklasEi/bevy_kira_audio#8) --- ## Changelog ### Added - Vorbis audio files may now use the `.oga` and `.spx` filename extensions in addition to the more common `.ogg` filename extension.
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 10, 2022
# Objective - Add two missing ogg vorbis audio extensions. ## Solution - Add the two missing extensions to the list - The file format is the same, there are simply two other possible extensions files can use. - This can be easily (manually) tested by renaming the extension of `assets/sounds/Windless Slopes.ogg` to end in either `.oga` or `.spx` (in both the filesystem and in `examples/audio/audio.rs`) and then running `cargo run --example audio` and observing that the music still plays. ## More info From the [wikipedia article for Ogg](https://en.wikipedia.org/wiki/Ogg): > Ogg audio media is registered as [IANA](https://en.wikipedia.org/wiki/Internet_Assigned_Numbers_Authority) [media type](https://en.wikipedia.org/wiki/Media_type) audio/ogg with file extensions .oga, .ogg, and [.spx](https://en.wikipedia.org/wiki/Speex). The current workaround is to rename any files ending in `.oga` or `.spx` to end in `.ogg` instead, which complicates tracking assets procured from other organizations. See also [a corresponding change to bevy_kira_audio](NiklasEi/bevy_kira_audio#8) --- ## Changelog ### Added - Vorbis audio files may now use the `.oga` and `.spx` filename extensions in addition to the more common `.ogg` filename extension.
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - Add two missing ogg vorbis audio extensions. ## Solution - Add the two missing extensions to the list - The file format is the same, there are simply two other possible extensions files can use. - This can be easily (manually) tested by renaming the extension of `assets/sounds/Windless Slopes.ogg` to end in either `.oga` or `.spx` (in both the filesystem and in `examples/audio/audio.rs`) and then running `cargo run --example audio` and observing that the music still plays. ## More info From the [wikipedia article for Ogg](https://en.wikipedia.org/wiki/Ogg): > Ogg audio media is registered as [IANA](https://en.wikipedia.org/wiki/Internet_Assigned_Numbers_Authority) [media type](https://en.wikipedia.org/wiki/Media_type) audio/ogg with file extensions .oga, .ogg, and [.spx](https://en.wikipedia.org/wiki/Speex). The current workaround is to rename any files ending in `.oga` or `.spx` to end in `.ogg` instead, which complicates tracking assets procured from other organizations. See also [a corresponding change to bevy_kira_audio](NiklasEi/bevy_kira_audio#8) --- ## Changelog ### Added - Vorbis audio files may now use the `.oga` and `.spx` filename extensions in addition to the more common `.ogg` filename extension.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Add two missing ogg vorbis audio extensions. ## Solution - Add the two missing extensions to the list - The file format is the same, there are simply two other possible extensions files can use. - This can be easily (manually) tested by renaming the extension of `assets/sounds/Windless Slopes.ogg` to end in either `.oga` or `.spx` (in both the filesystem and in `examples/audio/audio.rs`) and then running `cargo run --example audio` and observing that the music still plays. ## More info From the [wikipedia article for Ogg](https://en.wikipedia.org/wiki/Ogg): > Ogg audio media is registered as [IANA](https://en.wikipedia.org/wiki/Internet_Assigned_Numbers_Authority) [media type](https://en.wikipedia.org/wiki/Media_type) audio/ogg with file extensions .oga, .ogg, and [.spx](https://en.wikipedia.org/wiki/Speex). The current workaround is to rename any files ending in `.oga` or `.spx` to end in `.ogg` instead, which complicates tracking assets procured from other organizations. See also [a corresponding change to bevy_kira_audio](NiklasEi/bevy_kira_audio#8) --- ## Changelog ### Added - Vorbis audio files may now use the `.oga` and `.spx` filename extensions in addition to the more common `.ogg` filename extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
assets/sounds/Windless Slopes.oggto end in either.ogaor.spx(in both the filesystem and inexamples/audio/audio.rs) and then runningcargo run --example audioand observing that the music still plays.More info
From the wikipedia article for Ogg:
The current workaround is to rename any files ending in
.ogaor.spxto end in.ogginstead, which complicates tracking assets procured from other organizations.See also a corresponding change to bevy_kira_audio
Changelog
Added
.ogaand.spxfilename extensions in addition to the more common.oggfilename extension.