-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience method for polling Task<> #4627
base: main
Are you sure you want to change the base?
Conversation
Is this an alternative to #4102? If it is what are the advantages/disadvantages vs that PR? |
Lower overhead, as this doesn't require adding an extra channel, instead using what's already built into |
But if checking it is more expensive, then I would think that cost would dwarf the extra overhead of the channel. That is, I can't just let the claim of 'lower overhead' meaning better go by without confirmation - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the Controversial tag. I'd like to see perf testing here. The API is really simple and appealing, but I don't want that to turn into a footgun.
I added perf numbers here #4102 (comment). |
Objective
Checking if a task is completed and retrieving the value is too convoluted
Solution
Add a simple convenience method