Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Some minor cleanups of asset_server #4604

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Some minor cleanups of asset_server #4604

wants to merge 1 commit into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Apr 26, 2022

Objective

  • Code quality bad

Solution

  • Code quality better
  • Using rust-analyzer's inline function and inline variable quick assists, I validated that the call to AssetServer::new is exactly the same code as the previous version.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 26, 2022
@DJMcNab DJMcNab added A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Apr 26, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 26, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 26, 2022
@DJMcNab
Some minor cleanups of asset_server (#4604)
bc7293e 
# Objective

- Code quality bad

## Solution

- Code quality better
- Using rust-analyzer's inline function and inline variable quick assists, I validated that the call to `AssetServer::new` is exactly the same code as the previous version.
@bors
Copy link
Contributor

bors bot commented Apr 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Some minor cleanups of asset_server [Merged by Bors] - Some minor cleanups of asset_server Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
@DJMcNab DJMcNab deleted the asset_server_tiny branch April 26, 2022 21:07
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@DJMcNab @exjam
Some minor cleanups of asset_server (bevyengine#4604)
539fb0e 
# Objective

- Code quality bad

## Solution

- Code quality better
- Using rust-analyzer's inline function and inline variable quick assists, I validated that the call to `AssetServer::new` is exactly the same code as the previous version.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@DJMcNab @ItsDoot
Some minor cleanups of asset_server (bevyengine#4604)
558c270 
# Objective

- Code quality bad

## Solution

- Code quality better
- Using rust-analyzer's inline function and inline variable quick assists, I validated that the call to `AssetServer::new` is exactly the same code as the previous version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DJMcNab @alice-i-cecile @james7132 @mockersf