[Merged by Bors] - use const Vec2 in lights cluster and bounding box when possible #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Rendering
alice-i-cecile
added
C-Performance
| @@ -485,8 +487,7 @@ fn ndc_position_to_cluster( | |||
| view_z: f32, | |||
| ) -> UVec3 { | |||
| let cluster_dimensions_f32 = cluster_dimensions.as_vec3(); | |||
| let frag_coord = | |||
| (ndc_p.xy() * Vec2::new(0.5, -0.5) + Vec2::splat(0.5)).clamp(Vec2::ZERO, Vec2::ONE); | |||
| let frag_coord = (ndc_p.xy() * VEC2_HALF_NEGATIVE_Y + VEC2_HALF).clamp(Vec2::ZERO, Vec2::ONE); | |||
alice-i-cecile
approved these changes
Apr 26, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
superdump
requested changes
Apr 26, 2022
crates/bevy_pbr/src/light.rs
Outdated
| ) | ||
| } | ||
|
|
||
| const NDC_MIN: Vec3 = const_vec3!([-1.0, -1.0, f32::MIN]); | ||
| const NDC_MAX: Vec3 = const_vec3!([1.0, 1.0, f32::MAX]); |
There was a problem hiding this comment.
This is a misnomer. ndc min/max depth values are 0.0 and 1.0 as anything outside will be clipped. I’ll have a closer look what this bit of code is doing to see whether the values should be changed or whether there’s a more accurate name that can be used.
There was a problem hiding this comment.
I reordered the code to not need to clamp on a Vec3, but do it on the Vec2. The clamp on z was meaningless anyway as it was between f32::MIN and f32::MAX. This seem to be even a tad bit faster to execute 🎉
alice-i-cecile
removed
the
S-Ready-For-Final-Review
|
Removing the clamping is nice, good eye. |
mockersf
changed the title
superdump
approved these changes
May 4, 2022
mockersf
force-pushed
the
lights-use-const-vec3-clamping-bounds
branch
from
3bfdfbb
to
bb4e130
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 6, 2022
# Objective - noticed a few Vec3 and Vec2 that could be const ## Solution - Declared them as const - It seems to make a tiny improvement in example `many_light`, but given that the change is not complex at all it could still be worth it
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 10, 2022
…engine#4602) - noticed a few Vec3 and Vec2 that could be const - Declared them as const - It seems to make a tiny improvement in example `many_light`, but given that the change is not complex at all it could still be worth it
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 10, 2022
…engine#4602) - noticed a few Vec3 and Vec2 that could be const - Declared them as const - It seems to make a tiny improvement in example `many_light`, but given that the change is not complex at all it could still be worth it
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
…engine#4602) # Objective - noticed a few Vec3 and Vec2 that could be const ## Solution - Declared them as const - It seems to make a tiny improvement in example `many_light`, but given that the change is not complex at all it could still be worth it
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…engine#4602) # Objective - noticed a few Vec3 and Vec2 that could be const ## Solution - Declared them as const - It seems to make a tiny improvement in example `many_light`, but given that the change is not complex at all it could still be worth it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
many_light, but given that the change is not complex at all it could still be worth it