[Merged by Bors] - Remove EntityMut::get_unchecked #4547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRawMeatball
added
A-ECS
BoxyUwU
approved these changes
Apr 20, 2022
alice-i-cecile
approved these changes
Apr 20, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Looks good; we've been over this at length over in #3001. |
|
@TheRawMeatball, can you make a quick migration guide? This is technically a breaking change. |
alice-i-cecile
added
the
C-Breaking-Change
TheRawMeatball
force-pushed
the
yeet-get-unchecked
branch
from
e93211e
to
731c7d6
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 22, 2022
The only way to soundly use this API is already encapsulated within `EntityMut::get`, so this api is removed. # Migration guide Replace calls to `EntityMut::get_unchecked` with calls to `EntityMut::get`.
bors
bot
changed the title
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
The only way to soundly use this API is already encapsulated within `EntityMut::get`, so this api is removed. # Migration guide Replace calls to `EntityMut::get_unchecked` with calls to `EntityMut::get`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
The only way to soundly use this API is already encapsulated within `EntityMut::get`, so this api is removed. # Migration guide Replace calls to `EntityMut::get_unchecked` with calls to `EntityMut::get`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to soundly use this API is already encapsulated within
EntityMut::get, so this api is removed.Migration guide
Replace calls to
EntityMut::get_uncheckedwith calls toEntityMut::get.