[Merged by Bors] - Remove .system()
#4499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
approved these changes
Apr 16, 2022
tim-blackbird
approved these changes
Apr 16, 2022
MinerSebas
approved these changes
Apr 16, 2022
Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Apr 16, 2022
DJMcNab
added
the
C-Breaking-Change
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2022
Free at last! # Objective - Using `.system()` is no longer needed anywhere, and anyone using it will have already gotten a deprecation warning. - #3302 was a super special case for `.system()`, since it was so prevelant. However, that's no reason. - Despite it being deprecated, another couple of uses of it have already landed, including in the deprecating PR. - These have all been because of doc examples having warnings not breaking CI - 🎟️? ## Solution - Remove it. - It's gone --- ## Changelog - You can no longer use `.system()` ## Migration Guide - You can no longer use `.system()`. It was deprecated in 0.7.0, and you should have followed the deprecation warning then. You can just remove the method call.  - Thanks to the @TheRawMeatball for producing
Migration guide for doctests[EDITED] Thanks @DJMcNab for pointing out the more correct API. Use
- my_system.system();
+ bevy::ecs::system::assert_is_system(my_system); |
|
Why would you use |
|
Because I didn't know it existed 😝 |
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
Free at last! # Objective - Using `.system()` is no longer needed anywhere, and anyone using it will have already gotten a deprecation warning. - bevyengine#3302 was a super special case for `.system()`, since it was so prevelant. However, that's no reason. - Despite it being deprecated, another couple of uses of it have already landed, including in the deprecating PR. - These have all been because of doc examples having warnings not breaking CI - 🎟️? ## Solution - Remove it. - It's gone --- ## Changelog - You can no longer use `.system()` ## Migration Guide - You can no longer use `.system()`. It was deprecated in 0.7.0, and you should have followed the deprecation warning then. You can just remove the method call.  - Thanks to the @TheRawMeatball for producing
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
Free at last! # Objective - Using `.system()` is no longer needed anywhere, and anyone using it will have already gotten a deprecation warning. - bevyengine#3302 was a super special case for `.system()`, since it was so prevelant. However, that's no reason. - Despite it being deprecated, another couple of uses of it have already landed, including in the deprecating PR. - These have all been because of doc examples having warnings not breaking CI - 🎟️? ## Solution - Remove it. - It's gone --- ## Changelog - You can no longer use `.system()` ## Migration Guide - You can no longer use `.system()`. It was deprecated in 0.7.0, and you should have followed the deprecation warning then. You can just remove the method call.  - Thanks to the @TheRawMeatball for producing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Free at last!
Objective
.system()is no longer needed anywhere, and anyone using it will have already gotten a deprecation warning..system#3302 was a super special case for.system(), since it was so prevelant. However, that's no reason.Solution
Changelog
.system()Migration Guide
.system(). It was deprecated in 0.7.0, and you should have followed the deprecation warning then. You can just remove the method call.