Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Do not crash if RenderDevice doesn't exist #4427

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Do not crash if RenderDevice doesn't exist #4427

wants to merge 1 commit into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Apr 5, 2022

Objective

Avoid crashing if RenderDevice doesn't exist (required for headless mode).
Fixes #4392.

Solution

Use CompressedImageFormats::all() if there is no RenderDevice.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 5, 2022
@cart cart added A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash and removed S-Needs-Triage This issue needs to be labelled labels Apr 5, 2022
@cart
Copy link
Member

cart commented Apr 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 5, 2022
# Objective

Avoid crashing if `RenderDevice` doesn't exist (required for headless mode).
Fixes #4392.

## Solution

Use `CompressedImageFormats::all()` if there is no `RenderDevice`.
@bors bors bot changed the title Do not crash if RenderDevice doesn't exist [Merged by Bors] - Do not crash if RenderDevice doesn't exist Apr 5, 2022
@bors bors bot closed this Apr 5, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
# Objective

Avoid crashing if `RenderDevice` doesn't exist (required for headless mode).
Fixes bevyengine#4392.

## Solution

Use `CompressedImageFormats::all()` if there is no `RenderDevice`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Avoid crashing if `RenderDevice` doesn't exist (required for headless mode).
Fixes bevyengine#4392.

## Solution

Use `CompressedImageFormats::all()` if there is no `RenderDevice`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

headless_defaults example panics
2 participants