Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix glTF perspective camera projection #4006

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix glTF perspective camera projection #4006

wants to merge 1 commit into from

Conversation

kirusfg
Copy link
Contributor

@kirusfg kirusfg commented Feb 21, 2022 •
edited
Loading

Objective

Solution

  • Include the near and far clipping values from the perspective projection in the Camera struct; before that, they were both being defaulted to 0.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 21, 2022
@cart
Copy link
Member

cart commented Feb 21, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 21, 2022
@kirusfg
Fix glTF perspective camera projection (#4006)
b4bf5b5 
# Objective

- Fixes #4005 

## Solution

- Include the `near` and `far` clipping values from the perspective projection in the `Camera` struct; before that, they were both being defaulted to 0.
@mockersf mockersf added A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Feb 21, 2022
@bors
Copy link
Contributor

bors bot commented Feb 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix glTF perspective camera projection [Merged by Bors] - Fix glTF perspective camera projection Feb 21, 2022
@bors bors bot closed this Feb 21, 2022
@kirusfg kirusfg deleted the fix/gltf-camera-lighting branch February 22, 2022 09:08
kurtkuehnert pushed a commit to kurtkuehnert/bevy that referenced this pull request Mar 6, 2022
@kirusfg
Fix glTF perspective camera projection (bevyengine#4006)
d986ae8 
# Objective

- Fixes bevyengine#4005 

## Solution

- Include the `near` and `far` clipping values from the perspective projection in the `Camera` struct; before that, they were both being defaulted to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

glTF camera does not use the near and far values of perspective when imported
3 participants
@kirusfg @cart @mockersf