Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bevy_asset: Add AssetServerSettings watch_for_changes member #3643

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - bevy_asset: Add AssetServerSettings watch_for_changes member #3643

wants to merge 3 commits into from

Commits on Jan 23, 2022

  1. bevy_asset: Add AssetServerSettings watch_for_changes member 

    asset_server.watch_for_changes().unwrap() only watches changes for assets
loaded _after_ that call. Technically, hot_asset_reloading was racey as the
watch on the asset path is set up in an async task. As such, it feels safest to
allow enabling watching for changes on the asset server from the point of
construction, and so adding such an option to AssetServerSettings seemed to be
the correct solution.
    @superdump
    superdump committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    7ab3baa View commit details
    Browse the repository at this point in the history

  2. bevy_asset: Fix FileAssetIo::new usage in test

    @superdump
    superdump committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    fe3d13d View commit details
    Browse the repository at this point in the history

  3. Make public API consistent independent of enabled features

    @superdump
    superdump committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    23dea8b View commit details
    Browse the repository at this point in the history