[Merged by Bors] - Configurable wgpu features/limits priority #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
Update WgpuOptions with the changes. Expose WgpuOptions resource to render app.
superdump
force-pushed
the
wgpu-features-limits
branch
from
32b639a
to
549cc35
Compare
superdump
force-pushed
the
wgpu-features-limits
branch
from
549cc35
to
18b663e
Compare
|
Seems reasonable to me! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
# Objective - Allow the user to specify the priority when configuring wgpu features/limits and by default use the maximum capabilities of the chosen adapter. ## Solution - Add a `WgpuOptionsPriority` enum with `Compatibility`, `Functionality` and `WebGL2` options. - Add a `priority: WgpuOptionsPriority` member to `WgpuOptions`. - When initialising the renderer, if `WgpuOptions::priority == WgpuOptionsPriority::Functionality`, query the adapter for the available features and limits, use them when creating a device, and update `WgpuOptions` with those values. If `Compatibility` use the behaviour as before this PR. If `WebGL2` then use the WebGL2 downlevel limits as used when when building for wasm, for convenience of testing WebGL2 limits without having to build for wasm. - Add an environment variable `WGPU_OPTIONS_PRIO` that takes `compatibility`, `functionality`, `webgl2`. - Default to `WgpuOptionsPriority::Functionality`. - Insert updated `WgpuOptions` into render app world as well. This is useful for applying the limits when rendering, such as limiting the directional light shadow map texture to 2048x2048 when using WebGL2 downlevel limits but not on wasm. - Reduced `draw_state` logs from `debug` to `trace` and added `debug` level logs for the wgpu features and limits. Use `RUST_LOG=bevy_render=debug` to see the output.
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
WgpuOptionsPriorityenum withCompatibility,FunctionalityandWebGL2options.priority: WgpuOptionsPrioritymember toWgpuOptions.WgpuOptions::priority == WgpuOptionsPriority::Functionality, query the adapter for the available features and limits, use them when creating a device, and updateWgpuOptionswith those values. IfCompatibilityuse the behaviour as before this PR. IfWebGL2then use the WebGL2 downlevel limits as used when when building for wasm, for convenience of testing WebGL2 limits without having to build for wasm.WGPU_OPTIONS_PRIOthat takescompatibility,functionality,webgl2.WgpuOptionsPriority::Functionality.WgpuOptionsinto render app world as well. This is useful for applying the limits when rendering, such as limiting the directional light shadow map texture to 2048x2048 when using WebGL2 downlevel limits but not on wasm.draw_statelogs fromdebugtotraceand addeddebuglevel logs for the wgpu features and limits. UseRUST_LOG=bevy_render=debugto see the output.