Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - use ogg by default instead of mp3 #3421

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - use ogg by default instead of mp3 #3421

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 23, 2021 •
edited
Loading

Objective

  • mp3 feature of rodio has dependencies that are not maintained with security issues
  • mp3 feature of rodio doesn't build in wasm
  • mp3 feature of rodio uses internal memory allocation that cause rejection from Apple appstore

Solution

  • Use vorbis instead of mp3 by default

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 23, 2021
@mockersf mockersf added A-Audio Sounds playback and modification and removed S-Needs-Triage This issue needs to be labelled labels Dec 23, 2021
alice-i-cecile
alice-i-cecile approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an important stopgap solution. We can at least reduce the pain here.

Ixentus
Ixentus approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@Ixentus Ixentus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This brings us closer to being able to build for wasm without disabling default features.

Although a lot of people use mp3, they really shouldn't. It's easy to mass convert mp3 to ogg.

@mockersf
Copy link
Member Author

Yup, with this change Bevy builds in wasm with the default features

@alice-i-cecile alice-i-cecile added C-Dependencies A change to the crates that Bevy depends on O-Web Specific to web (WASM) builds S-Needs-Migration-Guide labels Dec 23, 2021
@cart
Copy link
Member

cart commented Dec 23, 2021

I agree that this is the best short term move, especially given that there are already long term solutions in the works (Symphonia backends and/or minimp3 dependency fixes). Bevy should work everywhere by default and people that really want mp3 support can just enable the feature.

@cart
Copy link
Member

cart commented Dec 23, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 23, 2021
@mockersf
use ogg by default instead of mp3 (#3421)
aeba9fa 
# Objective

- mp3 feature of rodio has dependencies that are not maintained with security issues
- mp3 feature of rodio doesn't build in wasm
- mp3 feature of rodio uses internal memory allocation that cause rejection from Apple appstore

## Solution

- Use vorbis instead of mp3 by default


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 23, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title use ogg by default instead of mp3 [Merged by Bors] - use ogg by default instead of mp3 Dec 23, 2021
@bors bors bot closed this Dec 23, 2021
@mockersf mockersf mentioned this pull request Dec 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ixentus Ixentus Ixentus approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on O-Web Specific to web (WASM) builds
Projects
Audio
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @cart @Ixentus @alice-i-cecile