[Merged by Bors] - Do not panic on failed setting of GameOver state in AlienCakeAddict #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be more correct game-wise to use |
|
bors r+ |
bors
bot
changed the title
mockersf
added
C-Bug
bors bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
# Objective Examples should use the correct tools for the job. ## Solution A fixed timestep, by design, can step multiple times consecutively in a single update. That property used to crash the `alien_cake_addict` example (#2525), which was "fixed" in #3411 (by just not panicking). The proper fix is to use a timer instead, since the system is supposed to spawn a cake every 5 seconds. --- A timer guarantees a minimum duration. A fixed timestep guarantees a fixed number of steps per second. Each one works by essentially sacrificing the other's guarantee. You can use them together, but no other systems are timestep-based in this example, so the timer is enough.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…yengine#5760) # Objective Examples should use the correct tools for the job. ## Solution A fixed timestep, by design, can step multiple times consecutively in a single update. That property used to crash the `alien_cake_addict` example (bevyengine#2525), which was "fixed" in bevyengine#3411 (by just not panicking). The proper fix is to use a timer instead, since the system is supposed to spawn a cake every 5 seconds. --- A timer guarantees a minimum duration. A fixed timestep guarantees a fixed number of steps per second. Each one works by essentially sacrificing the other's guarantee. You can use them together, but no other systems are timestep-based in this example, so the timer is enough.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…yengine#5760) # Objective Examples should use the correct tools for the job. ## Solution A fixed timestep, by design, can step multiple times consecutively in a single update. That property used to crash the `alien_cake_addict` example (bevyengine#2525), which was "fixed" in bevyengine#3411 (by just not panicking). The proper fix is to use a timer instead, since the system is supposed to spawn a cake every 5 seconds. --- A timer guarantees a minimum duration. A fixed timestep guarantees a fixed number of steps per second. Each one works by essentially sacrificing the other's guarantee. You can use them together, but no other systems are timestep-based in this example, so the timer is enough.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…yengine#5760) # Objective Examples should use the correct tools for the job. ## Solution A fixed timestep, by design, can step multiple times consecutively in a single update. That property used to crash the `alien_cake_addict` example (bevyengine#2525), which was "fixed" in bevyengine#3411 (by just not panicking). The proper fix is to use a timer instead, since the system is supposed to spawn a cake every 5 seconds. --- A timer guarantees a minimum duration. A fixed timestep guarantees a fixed number of steps per second. Each one works by essentially sacrificing the other's guarantee. You can use them together, but no other systems are timestep-based in this example, so the timer is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
alien_cake_addictexample in valgrind #2525.Solution
Result, rather than panicking. We could probably handle this better, but I want to see if this works first. Ping @qarmin.