Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Improved bevymark: no bouncing offscreen and spawn waves from CLI #3364

Closed
wants to merge 6 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 17, 2021

Objective

  • In bevymark, bevies were very bouncy and could go off screen after a while, skewing the FPS
bouncy-bevymark.mp4

Solution

  • Make bevies bounce also on top of the screen
  • I also changed how the examples read args from CLI to be able to spawn waves: cargo run --example bevymark --release -- 5 100 (first is number of bevy per wave, second is number of wave, with one wave every 0.2 seconds). This makes it easier to reproduce some exact situations
waved-bevymark.mp4

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 17, 2021
@mockersf mockersf added C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Dec 17, 2021
examples/tools/bevymark.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Dec 17, 2021
mockersf and others added 3 commits December 18, 2021 10:57
Co-Authored-By: bjorn3 <bjorn3@users.noreply.github.com>
@cart
Copy link
Member

cart commented Dec 18, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 18, 2021
)

# Objective

- In bevymark, bevies were very bouncy and could go off screen after a while, skewing the FPS

https://user-images.githubusercontent.com/8672791/146540848-282fa11b-d058-4da9-8e95-688ae67d9406.mp4

## Solution

- Make bevies bounce also on top of the screen
- I also changed how the examples read args from CLI to be able to spawn waves: `cargo run --example bevymark --release -- 5 100` (first is number of bevy per wave, second is number of wave, with one wave every 0.2 seconds). This makes it easier to reproduce some exact situations

https://user-images.githubusercontent.com/8672791/146542857-2f953fa0-7b8d-4772-93f8-b8d7a31259dc.mp4




Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors bors bot changed the title Improved bevymark: no bouncing offscreen and spawn waves from CLI [Merged by Bors] - Improved bevymark: no bouncing offscreen and spawn waves from CLI Dec 18, 2021
@bors bors bot closed this Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants