Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add default standard material in PbrBundle #3325

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - add default standard material in PbrBundle #3325

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Add a default standard material that is very visible. It is similar to the previous standard material that was used

Screenshot 2021-12-14 at 15 39 01

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 14, 2021
@jakobhellermann jakobhellermann added A-Rendering Drawing game state to the screen C-Regression Functionality that used to work but no longer does. Add a test for this! C-Usability A simple quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Dec 14, 2021
@cart cart added this to the Bevy 0.6 milestone Dec 14, 2021
@cart
Copy link
Member

cart commented Dec 14, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 14, 2021
@mockersf
add default standard material in PbrBundle (#3325)
c825fda 
# Objective

- Fix #3323 


## Solution

- Add a default standard material that is very visible. It is similar to the previous standard material that was used

<img width="1392" alt="Screenshot 2021-12-14 at 15 39 01" src="https://user-images.githubusercontent.com/8672791/146019401-ed4b5fc1-7cce-4a8f-a511-a6f9665a51d7.png">



Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add default standard material in PbrBundle [Merged by Bors] - add default standard material in PbrBundle Dec 14, 2021
@bors bors bot closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobhellermann jakobhellermann jakobhellermann approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Regression Functionality that used to work but no longer does. Add a test for this! C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
Bevy 0.6
Development

Successfully merging this pull request may close these issues.

Running 3d_scene example, with default material, causes object to be invisible
4 participants
@mockersf @cart @jakobhellermann @MrGVSV