[Merged by Bors] - Ported WgpuOptions to bevy_render2 #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
reviewed
Dec 9, 2021
folke
force-pushed
the
render2_wgpuoptions
branch
from
fdb33f7
to
6df739f
Compare
cart
reviewed
Dec 9, 2021
folke
force-pushed
the
render2_wgpuoptions
branch
from
6df739f
to
9786197
Compare
|
bors r+ |
cart
approved these changes
Dec 9, 2021
bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
# Objective The new renderer does not support any options yet for wgpu. These are needed for example for rendering wireframes (see #3193). ## Solution I've ported WgpuOptions to bevy_render2. The defaults match the defaults that were used before this PR (meaning, some specific options when target_arch = wasm32). Additionally, I removed `Auto` from WgpuBackends and added `Primary`. The default will use primary or GL based on the target_arch.
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The new renderer does not support any options yet for wgpu. These are needed for example for rendering wireframes (see #3193).
Solution
I've ported WgpuOptions to bevy_render2.
The defaults match the defaults that were used before this PR (meaning, some specific options when target_arch = wasm32).
Additionally, I removed
Autofrom WgpuBackends and addedPrimary. The default will use primary or GL based on the target_arch.