[Merged by Bors] - Fix clippy errors related to IntoIter::new #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are from the old and new renderer. For the 0.6 release, the old one will be removed and completely replaced with the new one (all the crates in |
mockersf
approved these changes
Dec 6, 2021
BoxyUwU
reviewed
Dec 6, 2021
crates/bevy_render/src/mesh/mesh.rs
Outdated
| @@ -464,7 +464,7 @@ impl Mesh { | |||
| let normals: Vec<_> = positions | |||
| .chunks_exact(3) | |||
| .map(|p| face_normal(p[0], p[1], p[2])) | |||
| .flat_map(|normal| std::array::IntoIter::new([normal, normal, normal])) | |||
| .flat_map(|normal| [normal, normal, normal].into_iter()) | |||
There was a problem hiding this comment.
why is the into_iter call necessary, wouldn't it just work to return the array?
There was a problem hiding this comment.
Removed into_iter call
Ratysz
approved these changes
Dec 6, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
# Objective
Fixes recent pipeline errors:
```
error: use of deprecated associated function `std::array::IntoIter::<T, N>::new`: use `IntoIterator::into_iter` instead
--> crates/bevy_render/src/mesh/mesh.rs:467:54
|
467 | .flat_map(|normal| std::array::IntoIter::new([normal, normal, normal]))
| ^^^
|
= note: `-D deprecated` implied by `-D warnings`
Compiling bevy_render2 v0.5.0 (/home/runner/work/bevy/bevy/pipelined/bevy_render2)
error: use of deprecated associated function `std::array::IntoIter::<T, N>::new`: use `IntoIterator::into_iter` instead
--> pipelined/bevy_render2/src/mesh/mesh/mod.rs:287:54
|
287 | .flat_map(|normal| std::array::IntoIter::new([normal, normal, normal]))
| ^^^
|
= note: `-D deprecated` implied by `-D warnings`
error: could not compile `bevy_render` due to previous error
```
## Solution
- Replaced `IntoIter::new` with `IntoIterator::into_iter`
## Suggestions
For me it looks like two equivalent `Mesh` structs with the same methods. Should we refactor it? Or, they will be different in the near future?
Co-authored-by: CrazyRoka <rokarostuk@gmail.com>
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
# Objective - Checks for NaN in computed NDC space coordinates, fixing unexpected NaN in a fallible (`Option<T>`) function. ## Solution - Adds a NaN check, in addition to the existing NDC bounds checks. - This is a helper function, and should have no performance impact to the engine itself. - This will help prevent hard-to-trace NaN propagation in user code, by returning `None` instead of `Some(NaN)`. Depends on #3269 for CI error fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes recent pipeline errors:
Solution
IntoIter::newwithIntoIterator::into_iterSuggestions
For me it looks like two equivalent
Meshstructs with the same methods. Should we refactor it? Or, they will be different in the near future?