Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Check for NaN in Camera::world_to_screen() #3268

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Check for NaN in Camera::world_to_screen() #3268

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b49fcb0
Check for NaN in `Camera::world_to_screen()`
aevyrie Dec 6, 2021
c2dae68
Add to pipelined cam, improve nan check
aevyrie Dec 6, 2021
1c6756a
Merge branch 'bevyengine:main' into main
aevyrie Dec 6, 2021
9c21567
Correct comment text in pipelined
aevyrie Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/bevy_render/src/camera/camera.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ impl Camera {
let world_to_ndc: Mat4 =
self.projection_matrix * camera_transform.compute_matrix().inverse();
let ndc_space_coords: Vec3 = world_to_ndc.project_point3(world_position);
// NDC z-values outside of 0 < z < 1 are behind the camera and are thus not in screen space
if ndc_space_coords.z < 0.0 || ndc_space_coords.z > 1.0 {
// NDC z-values outside of 0 < z < 1 are outside the camera frustum and are thus not in screen space
if ndc_space_coords.z < 0.0 || ndc_space_coords.z > 1.0 || ndc_space_coords.z.is_nan() {
return None;
}
// Once in NDC space, we can discard the z element and rescale x/y to fit the screen
Expand Down