Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add shadows in examples #3201

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - add shadows in examples #3201

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Add shadows in examples

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 27, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Nov 27, 2021
@mockersf mockersf mentioned this pull request Nov 27, 2021
Closed
@superdump
Copy link
Contributor

Thanks for doing this. I think also load_gltf_pipelined should have them reenabled. I didn’t check for other possibilities but that one sticks out in my mind.

@mockersf
Copy link
Member Author

added in load_gltf_pipelined too 👍

@alice-i-cecile alice-i-cecile added this to the Bevy 0.6 milestone Nov 27, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 27, 2021
@mockersf
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 27, 2021
@mockersf
add shadows in examples (#3201)
e8412df 
# Objective

- As mentioned in #3126, shadows need to be readded in examples

## Solution

- Add shadows in examples
@bors
Copy link
Contributor

bors bot commented Nov 27, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add shadows in examples [Merged by Bors] - add shadows in examples Nov 27, 2021
@bors bors bot closed this Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @superdump @alice-i-cecile